-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: show incorrect value on test failure #16818
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
Issues and PRs related to the async hooks subsystem.
test
Issues and PRs related to the tests.
labels
Nov 6, 2017
cjihrig
approved these changes
Nov 6, 2017
gireeshpunathil
approved these changes
Nov 6, 2017
Trott
added
the
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
Nov 6, 2017
Trott
approved these changes
Nov 7, 2017
CI was behaving strangely. Let's try again. |
XadillaX
approved these changes
Nov 7, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2017
PR-URL: nodejs#16818 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
Landed in 09c152e. |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 7, 2017
PR-URL: nodejs#16818 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #16818 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
async_hooks
Issues and PRs related to the async hooks subsystem.
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test